stride icon indicating copy to clipboard operation
stride copied to clipboard

Nullable and Modernization for Stride.Core.Serialization

Open IXLLEGACYIXL opened this issue 1 year ago • 1 comments

PR Details

Modernizing Stride.Core.Reflection

Description

  1. Should enable Nullable instead of Strides NotNull attribute
  2. Should reduce the usage of reflection, mainly used in collection Descriptors ( thats now prototyped for Dictionary, if its in interested i can convert set and list and the others too )
  3. Using new C# features ie collection initialization, Pattern Matching etc

Related Issue

#2156 Removes all [NotNull] annotations and uses the new Nullable Removes a bug

Motivation and Context

Types of changes

  • [x] Docs change / refactoring / dependency upgrade ( some comments changed )
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • [ ] My change requires a change to the documentation.
  • [ ] I have added tests to cover my changes.
  • [ ] All new and existing tests passed.
  • [ ] I have built and run the editor to try this change out.

IXLLEGACYIXL avatar May 22 '24 02:05 IXLLEGACYIXL

would be ready for review

dont know what oldcollection descriptor does to be still required

some nullable warnings are still existent but i dont know how to resolve them

IXLLEGACYIXL avatar May 24 '24 13:05 IXLLEGACYIXL

ran tests and they fail currently, maybe its a compilation issue... lets see..

IXLLEGACYIXL avatar May 27 '24 20:05 IXLLEGACYIXL

WELL sample tests fail but on all branches with latest main, but the descriptor tests and all other engien tests pass so it seems good

IXLLEGACYIXL avatar May 29 '24 17:05 IXLLEGACYIXL

Yep, it's good, TC reported 4 failing tests but those are unrelated, see #2296

Eideren avatar May 29 '24 21:05 Eideren

Thanks !

Eideren avatar May 29 '24 21:05 Eideren