stride icon indicating copy to clipboard operation
stride copied to clipboard

Move or remove problematic shared code within the same application, part 1

Open jrinker03 opened this issue 3 years ago • 0 comments

PR Details

This change is related to duplicated code in the same application causing compiler issues. This change either moves or removes duplicate references to shared code within the same end application.

Some of the shared code turns out to be obsolete related to live debugging in Studio. In this case, this change also removes the related code as well.

Description

There are three types of changes which are reasonably benign:

  • Some shared projects were no longer needed in projects that referenced them, so the reference was removed. For example, Stride.NuGetResolver
  • In the case of Stride.Core.ShellHelper, moving the code to a common, existing assembly was the simple solution.
  • The more wide-spread change was removing code related to an obsolete 'edit and continue'-like mode that leveraged shared code that itself becomes obsolete. It's possible that I might have missed related code so welcome reviewer's input on this part of the work.

This PR does not try to tackle the entirety of #1422 as I expect the rest will require some continued thought and discussion.

Related Issue

#1422

Motivation and Context

Continuing to chip away at improving the codebase's hygiene.

Types of changes

  • [ ] Docs change / refactoring / dependency upgrade
  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • [ ] My change requires a change to the documentation.
  • [ ] I have added tests to cover my changes.
  • [x] All new and existing tests passed.

jrinker03 avatar May 04 '22 15:05 jrinker03