network icon indicating copy to clipboard operation
network copied to clipboard

streamr-1.0 fix-start-and-stop-of-autocertifier-client

Open ptesavol opened this issue 2 years ago • 0 comments

This is the fix-start-and-stop-of-autocertifier-client pull request moved to base upon streamr-1.0 instead of testnet-one

  • make test/end-to-end/RecoveryFromFailedAutoCertification.test.ts to stop the entrypoint last to prevent nodes from starting to reconnect through the stopped entrypoint at the end of the test
  • rename WebsocketConnector's autoCertify() method to startAutoCertifierClient() as this is what the method does
  • stop AutoCertifierClientFacade in WebsocketConnector if it was started
  • start AutoCertifierClient in AutoCertifierClientFacade using an abortable withTimeout() instead of waitForEvent3 (using a async function as waitForEvent3 predicate caused the timeout to keep running in case the predicate threw an exception, which was the reason for test/end-to-end/RecoveryFromFailedAutoCertification.test.ts to hang)
  • because of the above changes test/end-to-end/RecoveryFromFailedAutoCertification.test.ts does not hang anymore

ptesavol avatar Dec 08 '23 10:12 ptesavol