charts icon indicating copy to clipboard operation
charts copied to clipboard

[charts/pulsar] adding flag webSocketServiceEnabled cm

Open yuweisung opened this issue 3 years ago • 3 comments

Motivation

  • According to the doc, proxy supports websocket but the broker and proxy cm template have no option to turn it on.*

Modifications

The proxy-configmap.yaml and broker-configmap.yaml are modified to enable websocket services.

Verifying this change

  • [ ] Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

Documentation

Check the box below.

Need to update docs?

  • [ x ] no-need-doc

    (Please explain why)

yuweisung avatar May 03 '22 20:05 yuweisung

@fantapsody I think there is no need to enable ws on broker, https://github.com/streamnative/charts/blob/master/charts/pulsar/values.yaml#L1291 allows to enable websocket on proxy.

ericsyh avatar May 06 '22 07:05 ericsyh

@ericsyh what happens when we use istio and the proxy is disabled?

polyzos avatar May 06 '22 13:05 polyzos

@ericsyh what happens when we use istio and the proxy is disabled?

@polyzos You mean the scenario that enabled Istio but wanna to use the websocket right? I think it's quite a good point, the proxy now has to been disabled cause there is a bug in the proxy that it cannot forward HTTP requests correctly when mTLS is on. If this problem is fixed, proxy can work with Istio.

So for the websocket, if currently no specific request for using websocket with Istio enabled, i prefer waiting for the proxy bug fixing.

ericsyh avatar May 07 '22 00:05 ericsyh