[charts/pulsar] Add ability to specify the cert-manager apiVersion
Motivation
Without enabled TLS the helm-controller refuses the helmrelease by the reason:
Helm install failed: error while running post render on files: map[string]interface {}(nil): yaml: unmarshal errors:
line 43: mapping key "brokerServiceURL" already defined at line 41
line 44: mapping key "brokerWebServiceURL" already defined at line 42
This should be solved to enable:
tls:
enabled: true
broker:
enabled: true
The condition is here. But when trying to use the cert-manager and internal_issuer, the certs are not issued because the templates are using deprecated apiVersion cert-manager.io/v1alpha2.
Modifications
Adding ability to specify the cert-manager apiVersion.
Documentation
- [x] no-need-doc
I'm not sure if this change needs a docs change.
@pavel-hladik:Thanks for your contribution. For this PR, do we need to update docs? (The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)
The one question I have is if the schema for the spec section is correct in the "tls-certs-internal.yaml" if you use the newer cert manager?
From what I have found these items in the spec section are not valid with the newer cert-manager.io/v1:
-
organization( it seems to be undersubject.organizations) -
keySize( it seems to be underprivateKey.size) -
keyAlgorithm( it seems to be underprivateKey.algorithm) -
keyEncoding( it seems to be underprivateKey.encoding)
The one question I have is if the schema for the spec section is correct in the "tls-certs-internal.yaml" if you use the newer cert manager?
From what I have found these items in the spec section are not valid with the newer cert-manager.io/v1:
organization( it seems to be undersubject.organizations)keySize( it seems to be underprivateKey.size)keyAlgorithm( it seems to be underprivateKey.algorithm)keyEncoding( it seems to be underprivateKey.encoding)
Hi, pls see my update. I already tested my modification and it works.
Looks good to me and the quick test I ran on my end worked also! Thanks for the help with this!
@sijie could you please help verify whether we need to add/update doc for this PR? Thanks
Hi! Any update on this?
Close this in favor of #807