aop icon indicating copy to clipboard operation
aop copied to clipboard
verified publisher icon streamnative

[fix]autoDelete exchange test

Open freshtang opened this issue 3 years ago • 4 comments

Master Issue: #63

Motivation

support autoDelete exchange and autoDelete queue autoDelete exchange: exchange is deleted when last queue is unbound from it autoDelete queue: queue that has had at least one consumer is deleted when last consumer unsubscribes more detail: https://www.rabbitmq.com/tutorials/amqp-concepts.html

Modifications

Describe the modifications you've done.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

  • [x] no-need-doc

freshtang avatar Jul 13 '22 14:07 freshtang

I have fixed the conflicts, maybe support autoDelete queue with a new PR

freshtang avatar Jul 31 '22 03:07 freshtang

Thanks for your contribution!

Sorry for the late response, it seems this PR only saves the auto-delete flag in the properties, right? This PR https://github.com/streamnative/aop/pull/646 support saving exchange properties when first initializing the exchange, and supports exchange declare parameter conflict check. Maybe it can resolve this problem, could you take a look at it? Thanks

gaoran10 avatar Oct 19 '22 13:10 gaoran10

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Oct 21 '22 02:10 CLAassistant

This PR #646 can resolve this problem， but need to fix the null exception

freshtang avatar Oct 21 '22 02:10 freshtang