react-use
react-use copied to clipboard
Fixed the launch of the useEffect if the state outside has changed
Description
Fixed the launch of the useEffect if the state outside has changed (makes an extra render)
Example
const useBreakpoint = createBreakpoint();
const Component = () => {
const breakpoint = useBreakpoint();
const [count, setCount] = useState(0);
const onClick = useCallback(() => {
setCount(value => value + 1);
}, []);
console.log(count);
return (
<div>
<button onClick={onClick}>Click</button>
<p>{count}</p>
<p>{breakpoint}</p>
</div>
);
};
Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as before)
Checklist
- [x] Read the Contributing Guide
- [x] Perform a code self-review
- [x] Comment the code, particularly in hard-to-understand areas
- [x] Add documentation
- [x] Add hook's story at Storybook
- [x] Cover changes with tests
- [x] Ensure the test suite passes (
yarn test) - [x] Provide 100% tests coverage
- [x] Make sure code lints (
yarn lint). Fix it withyarn lint:fixin case of failure. - [x] Make sure types are fine (
yarn lint:types).
Hello, what about this fix?
Came here to open this same PR after implementing this library.
Causes infinite render and flood of console errors due to missing dependency array.
https://react.dev/reference/react/useEffect#my-effect-runs-after-every-re-render