StratosphereLinuxIPS icon indicating copy to clipboard operation
StratosphereLinuxIPS copied to clipboard

Use prefix instead of different ports in redis database - incomplete

Open A-atmos opened this issue 3 years ago • 3 comments

For Issue: #207

This PR isn't ready to merge, but is here to ask for recommendation

This PR passes the database tests, but alert.log isn't created, which result in failing of other integration tests!

A-atmos avatar Apr 14 '23 12:04 A-atmos

hey @A-atmos i just rebased your branch to the latest develop

the issue here is that no msgs are received in any channel because of the is_msg_intended_for() function in slips_utils this function doesn't have the prefix when checking for msgs if i were you i'd move it the db file, fix all modules accordingly, and change the function to use the prefix

thank you for the effort this is a really tough issue!

AlyaGomaa avatar Apr 14 '23 14:04 AlyaGomaa

Thank you for the appreciation. I'm doing my best to resolve this issue, but I'm still facing some issues in the integration tests. I moved the utils.is_msg_intended_for() in database.py and refactored the code accordingly. I'm not getting any errors while testing database and other individual tests, but while testing the integration tests, I'm still facing some issues. But I'm trying to fix them. I'll get this issue resolved as soon as possible. Thanks again!

A-atmos avatar Apr 16 '23 12:04 A-atmos

hey @A-atmos integration tests run on files in our dataset/, try to see which file is failing in the test and then run slips normally on that file and check what errors it gives you also you may need to modify the database fixture in conftest.py to match the new changes in the db

AlyaGomaa avatar Apr 17 '23 15:04 AlyaGomaa