rfcs icon indicating copy to clipboard operation
rfcs copied to clipboard

New auth Provider 'Apple SignIn'

Open Lith opened this issue 5 years ago • 12 comments

This RFC refer to https://github.com/strapi/strapi/issues/6586

RFC Preview link

Update I've begin a draft article about how to implement Apple Sign In right now on Strapi All feedback are welcome, I will update RFC informations and the PR about Apple SignIn soon.

Lith avatar Sep 21 '20 21:09 Lith

Thanks for this RFC ! Correct me If I'm wrong but from what I understand the only specific change is to add a POST route for the callback is that right ?

alexandrebodin avatar Sep 28 '20 14:09 alexandrebodin

Thanks for this RFC ! Correct me If I'm wrong but from what I understand the only specific change is to add a POST route for the callback is that right ?

With this implementation, yes, it's the "main" change, and we need to add a generateToken method with a variable that read the private key file. I've overload configuration this week for my website, I will send you an update with all changes.

My 2nd solution, implemented successfully on my website, send the redirect_uri to my client website, and the client (with access_token) send a GET request to Strapi, because, when you send a POST request, we loss the response body (Grant redirect) and we can not send it to the next method. Not sure if I'm clear about it...

I will try to make a drawing to explain different solution of implementation.

Also, I agree with @derrickmehaffy, maybe it will be interesting to have this as a plugin like email or upload.

Thanks,

Lith avatar Oct 01 '20 19:10 Lith

Also, I agree with @derrickmehaffy, maybe it will be interesting to have this as a plugin like email or upload.

One of those things we would love to do but lack the time at the moment, it requires a massive refactor to users-permissions and the scheduling of that is left entirely up to @sam-pires / @JabStrapi and the engineering teams.

derrickmehaffy avatar Oct 01 '20 20:10 derrickmehaffy

Is there anything left that needs to be done here that others could help with to get this added? @Lith were there changes you had locally you were planning to push?

glenselle avatar Dec 07 '20 20:12 glenselle

Thanks @Lith for your work on this issue

christophemacabiau avatar Dec 17 '20 13:12 christophemacabiau

Related article by @Lith (thank you :heart: )

https://medium.com/@vanessa.pasque/implement-apple-sign-in-with-strapi-a9f0ff4b6417

derrickmehaffy avatar Dec 28 '20 15:12 derrickmehaffy

CLA assistant check
All committers have signed the CLA.

strapi-cla avatar Jan 21 '21 13:01 strapi-cla

@derrickmehaffy Derrick, is there any news regarding this topic? The RFC is still open after such a long time. Unfortunately, Vanessa's tutorial on Medium isn't applicable anymore for V4. And looks like that was the only implementation that Google knows about...

mriabokliach avatar Jul 06 '22 21:07 mriabokliach

@derrickmehaffy Derrick, is there any news regarding this topic? The RFC is still open after such a long time. Unfortunately, Vanessa's tutorial on Medium isn't applicable anymore for V4. And looks like that was the only implementation that Google knows about...

Currently no as it requires us to purchase a dev license to properly test. A user in our discord was able to add apple login to users-permissions the other day.

derrickmehaffy avatar Jul 06 '22 23:07 derrickmehaffy

@derrickmehaffy I'd love to see AppleID sign-in method in strapi. Do not hesitate to reach me via email. I'll be happy to help (e.g. can create an app for testing purposes)

kkiermasz avatar Aug 17 '22 15:08 kkiermasz

@derrickmehaffy I'd love to see AppleID sign-in method in strapi. Do not hesitate to reach me via email. I'll be happy to help (e.g. can create an app for testing purposes)

As mentioned before, this isn't something we will likely implement as it requires us to purchase and maintain a license from Apple to do so, this is why we don't implement several other providers. Eventually we want to move the auth providers to their own packages much like we do with upload and email so that a community member can maintain an Apple one.

derrickmehaffy avatar Aug 17 '22 18:08 derrickmehaffy

I've created a PR for this one. Please have a look at it :)

https://github.com/strapi/strapi/pull/15522

EloB avatar Jan 23 '23 04:01 EloB