testing-react icon indicating copy to clipboard operation
testing-react copied to clipboard
verified publisher icon storybookjs

Fix path for export WebProjectAnnotations

Open TadeuA opened this issue 3 years ago • 3 comments

Issue: #18531 https://github.com/storybookjs/storybook/discussions/18531

What Changed

When using the library to test stories in a TS project, the build breaks because the import path of type WebProjectAnnotations was incorrect, with this change the problem is solved.

image

Checklist

Check the ones applicable to your change:

  • [ ] Tests are updated
  • [ ] Documentation is updated

Change Type

Indicate the type of change your pull request is:

  • [ ] documentation
  • [x] patch
  • [ ] minor
  • [ ] major

TadeuA avatar Sep 06 '22 16:09 TadeuA

A fix has already been merged: https://github.com/storybookjs/storybook/pull/19048

clintandrewhall avatar Sep 06 '22 16:09 clintandrewhall

A fix has already been merged: storybookjs/storybook#19048

I believe you have taken a slightly longer route, exporting from one library the module from another, but that solves it just the same, which is fine. Is your fix already available for use in some version?

TadeuA avatar Sep 06 '22 16:09 TadeuA

@TadeuA Confirmed fixed in 6.5.11, and the stack is at 6.5.12 now.

clintandrewhall avatar Sep 22 '22 16:09 clintandrewhall

Hey @TadeuA thanks a lot for your PR! Sorry for the late reply, but this seems to be no longer needed as there was a fix in Storybook 6.5.11.

I'll be closing this PR, thanks once again!

yannbf avatar Jan 11 '23 13:01 yannbf