testing-react icon indicating copy to clipboard operation
testing-react copied to clipboard

Update storybook pkg

Open sakit0 opened this issue 3 years ago • 4 comments

Issue: https://github.com/storybookjs/testing-react/issues/106

What Changed

  • Update Storybooks pkg
  • WebProjectAnnotations @storybook/preview-web to @storybook/store.
  • skipLibCheck to false

Checklist

Check the ones applicable to your change:

  • [ ] Tests are updated
  • [ ] Documentation is updated

Change Type

Indicate the type of change your pull request is:

  • [ ] documentation
  • [ ] patch
  • [ ] minor
  • [x] major

sakit0 avatar Aug 25 '22 06:08 sakit0

The build now succeeds. However, if skipLibCheck : false , the build fails. I think it would be better to set skipLibCheck : false.

This error occurs.

The inferred type of 'composeStory' cannot be named without a reference to '@storybook/client-api/node_modules/@storybook/csf'. This is likely not portable. A type annotation is necessary.

sakit0 avatar Aug 25 '22 07:08 sakit0

FYI: https://github.com/storybookjs/storybook/pull/19048 is also pending, which resolves it for shorter-term patch release.

clintandrewhall avatar Aug 30 '22 21:08 clintandrewhall

@clintandrewhall thank you! I will fix it to use when it is released.

sakit0 avatar Aug 30 '22 23:08 sakit0

skipLibCheck was set to false. This fixed the error. https://github.com/storybookjs/testing-react/pull/115#issuecomment-1226866885

The version of @storybook/csf was out of sync with @storybook/client-api and @storybook/store's dependencies on @storybook/csf, so we aligned them.

sakit0 avatar Aug 31 '22 11:08 sakit0

Hey @sakit0, thank you so much for your contribution! Given that Storybook 7.0 has reached beta, in the efforts of supporting it, I released 2.0.0-next.0 which supports Storybook 7 and does most changes you did in this PR, but in the new structure for Storybook 7.0.

Given that this PR is a breaking change for users that use 1.x.x, and we now have a 2.0.0 version that supports Storybook 7.0, and getting this released is going to be a lot of effort, so I'd rather have users migrate their Storybook to 7.0 instead, and they won't have any issues with testing-react v2.

I hope you understand, and I'll be closing this PR. Thank you so much once again for your time!

yannbf avatar Jan 11 '23 13:01 yannbf