react-native icon indicating copy to clipboard operation
react-native copied to clipboard

@storybook/addon-ondevice-notes: Markdown is very buggy

Open LaurensUP opened this issue 2 years ago • 7 comments

These are my findings and bugs with the Notes addon for React Native:

  • Headers need a newline to get formatting
# Button
Some text

doesn't format the heading

  • If you put the newline, the rest of the content disappears
# Button

Some text

-> Formats the heading, but Some text disappears

  • Documentation says you need a new line between each element, but if you do that, the things below your element don't get rendered

  • If you don't add a new line between your element, it works, but everything in the Notes section is on one line

// Doesn't work
    *Button*

    \`\`\`
    <Button variant="primary" title="Activate" />
    \`\`\`
    Main **button** in the application

// Works, but everything is on one line...
    *Button*
    \`\`\`
    <Button variant="primary" title="Activate" />
    \`\`\`
    Main **button** in the application

LaurensUP avatar Apr 26 '23 09:04 LaurensUP

@LaurensUP yeah it's unfortunate, when I was trying to fix it I couldn't find any good libraries. I'll take another look.

dannyhw avatar Apr 26 '23 10:04 dannyhw

@dannyhw what is the best way to write docs and descriptions for the components?

Michael-Ivlev avatar Jun 01 '23 11:06 Michael-Ivlev

@Michael-Ivlev seems pretty subjective to me and I'm not sure but it could be worth experimenting with this:

https://github.com/EvanBacon/expo-mdx/tree/main/packages/mdx

Then you could make custom render functions with mdx in them.

dannyhw avatar Jun 01 '23 12:06 dannyhw

heres an example I was experimenting with just now

image

dannyhw avatar Jun 01 '23 12:06 dannyhw

@dannyhw thank you but i use react native cli without expo, is it possible to use markdown in notes ? how can i do it ?

Michael-Ivlev avatar Jun 01 '23 12:06 Michael-Ivlev

@Michael-Ivlev as far as I know it doesn't require expo Notes isn't worth investing time into because the addon is deprecated on storybook core Though I mean technically I could make a NotesMdx addon that requires the MDX transformer

dannyhw avatar Jun 01 '23 13:06 dannyhw

Notes addon will be fixed to use a better markdown renderer in v7

dannyhw avatar Oct 22 '23 20:10 dannyhw