Turnstile icon indicating copy to clipboard operation
Turnstile copied to clipboard

Allow `createSession` to throw

Open hhanesand opened this issue 9 years ago • 2 comments

As I was writing my implementation of the protocol SessionManager, I realized I needed the createSession to be able to throw errors. After I create my session, I need to persist it to the our database, and that introduces a source of possible thrown errors that can not be propagated back to the network stack as createSession can not throw.

Would it be possible to change the method signature of the createSession method from

func createSession(account: Account) -> String

to

func createSession(account: Account) throws -> String

?

This would allow me to return an error in the HTTP request that initiated the session creation if the save operation failed.

hhanesand avatar Nov 11 '16 23:11 hhanesand

Yeah, this makes sense. Let me look into this more tomorrow and see what we can do =]

edjiang avatar Nov 14 '16 21:11 edjiang

I can throw a pull request your way if that makes things easier for you.

patched one together @ #20

hhanesand avatar Nov 15 '16 03:11 hhanesand