deploy icon indicating copy to clipboard operation
deploy copied to clipboard

Update uninstall.sh

Open Kyl-Bempah opened this issue 5 years ago • 6 comments

PR made for https://github.com/open-cluster-management/backlog/issues/6177, need to finish editing script.

Kyl-Bempah avatar Oct 21 '20 19:10 Kyl-Bempah

as part of the uninstall during canary i dont think we care about the rest of the manual cleanup

all we care is if mch is deleted successfully if mch delete hangs (with some timeout set) than we fail the testcase and move on

TheRealHaoLiu avatar Oct 27 '20 15:10 TheRealHaoLiu

any forward movement with this PR?

TheRealHaoLiu avatar Nov 03 '20 03:11 TheRealHaoLiu

Uninstall script has been added, watch of mch status and supplemental code paths need to be added to canary & canary-scripts.

Kyl-Bempah avatar Nov 03 '20 14:11 Kyl-Bempah

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Kyl-Bempah To complete the pull request process, please assign after the PR has been reviewed. You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot avatar Nov 19 '20 16:11 openshift-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Kyl-Bempah To complete the pull request process, please assign after the PR has been reviewed. You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot avatar Nov 19 '20 16:11 openshift-ci-robot

@Kyl-Bempah: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot avatar Apr 09 '21 12:04 openshift-ci-robot