application-samples icon indicating copy to clipboard operation
application-samples copied to clipboard

Fix typos and secret namespace

Open mbaldessari opened this issue 4 years ago • 1 comments

Without this change the secret never gets propagated to the other clusters. While we're at it, let's fix a couple of typos in the README and also s/secrets/secret/ so kustomize won't error out on this example.

With this change I was able to see the secret propagate to the other clusters. Without it the secret gets created in the default namespace and never gets picked up by the subscription.

mbaldessari avatar Jan 12 '22 19:01 mbaldessari

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mbaldessari To complete the pull request process, please assign fxiang1 after the PR has been reviewed. You can assign the PR to them by writing /assign @fxiang1 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Jan 12 '22 19:01 openshift-ci[bot]