Mitchell Austin
Mitchell Austin
I've become more confident that this is something we’ll want to do. I’ve had a go at fixing some of the issues individually and it can be done yet this...
Hi folks, pardon my slow response here. I’ve not thought this should be urgent so I’ve let it sit. @getdave, thanks for having a look and reading the prior comments....
> I think the scrollbar being within the iframe instead of being able to scroll the gray area is a dealbreaker. I do appreciate this concern and, as I said,...
> Zoom out is not a device preview. Right and my point does not conflate them nor say their scrolling has to work the same. It’s largely to make the...
> Didn't read all comments here, but did you check 100vh elements? Yes, and the first thing in testing instructions is `vh` units and your PR. > It worth nothing...
Here’s something that may need addressed at some point. The site icon in the header currently is rendered into a slot. Conceivably, there could be an app that chooses not...
> I'm a little anxious about hiding the title on mobile I wanted to keep it around at mobile. There’s enough room for it to be functional (providing we resolve...
> Probably unrelated, but potentially worth fixing here; I see a 'Preview' button on mobile, which is duplicative of the external icon button I looked into this some and that...
> Ah, I guess it's because the Preview action is bundled in the device preview toggles on desktop Right, thank you for reminding me. So the minor issue there is...
> I don't like some metric changes (`type` and `focus`) I appreciate you pointing that out. Looks like [this time around](https://github.com/WordPress/gutenberg/actions/runs/9780322604?pr=62636) `type` came out fine but not some of the...