react-tableau-embed-live icon indicating copy to clipboard operation
react-tableau-embed-live copied to clipboard

Support for authoring

Open kasza-introhive opened this issue 2 years ago • 4 comments

Will you be adding support for authoring/editing? I'm assuming this isn't implemented yet because I don't see the web component in the repo but maybe there's a different way of embedding workbook editing that I'm unfamiliar with. Thanks!

kasza-introhive avatar Aug 03 '23 18:08 kasza-introhive

Hi @kasza-introhive , good question! I personally don't have any experience with authoring tableau on the web so I have not included it in this library. If that's something people would find useful I think it would be a great addition.

Unofficially, I think this library would still work with the web component. You could try adding a prop and substituting it in TableauViz (e.g., see code below).

// TODO add `useAuthoring` to prop type interface
// ... Line 280:
  if (props.useAuthoring) 
     return <tableau-authoring-viz id="tableauViz" ref={vizRef} {...props}></tableau-authoring-viz>;
  return <tableau-viz id="tableauViz" ref={vizRef} {...props}></tableau-viz>;
// ...

Again, personally I have no experience using tableau web authoring so I don't have a good idea what features, and functionality folks will be looking for. Tableau is sometimes difficult to work with and some features don't work as documented so I'm hesitant to add anything to this library without a working test. That said, please share if you get it working and I'll incorporate your solution!!

stoddabr avatar Aug 05 '23 18:08 stoddabr

Hey @stoddabr. I created a PR to add support for web authoring. What kind of tests did you want to see for it? Just to verify the prop is received in the component?

kasza-introhive avatar Aug 28 '23 12:08 kasza-introhive

I think this is a great idea. I would prefer web authoring be it's own component so that the props don't conflict. If someone else has this issue I will start working on a fix

stoddabr avatar Oct 26 '23 21:10 stoddabr

I think this is a great idea. I would prefer web authoring be it's own component so that the props don't conflict. If someone else has this issue I will start working on a fix

Just want to say thanks for this project, it looks great! I am only new to tableau and am not yet needing authoring but will in the future.

Will be contributing later down the track once I start using tableau more.

tomarks avatar Oct 27 '23 05:10 tomarks