stitches icon indicating copy to clipboard operation
stitches copied to clipboard

test app: unpin a bunch of deps to fix CI

Open zackse opened this issue 2 years ago • 1 comments

Problem

CI failures after sqlite 2.0.0 was released

An error occurred while loading ./spec/valid_mime_type_spec.rb. - Did you mean?
                    rspec ./spec/valid_mime_type_middleware_spec.rb

Failure/Error: ActiveRecord::Base.establish_connection adapter: "sqlite3", database: ":memory:"

LoadError:
  Error loading the 'sqlite3' Active Record adapter. Missing a gem it depends on? can't activate sqlite3 (~> 1.4), already activated sqlite3-2.0.0-x86_64-linux-gnu. Make sure all dependencies are added to Gemfile.

Here's a diff of the bundle install step with the previously-working case on the left and the broken case on the right:

--- working  2024-04-19 14:29:30
+++ busted  2024-04-19 14:29:30
-Fetching sqlite3 1.7.3 (x86_64-linux)
+Fetching sqlite3 2.0.0 (x86_64-linux-gnu)

Solution

Unpin the ancient versions in the test app's Gemfile. Maybe they should still be pinned, but to newer versions? I don't know.

Also need to wait for https://github.com/rails/rails/pull/51592 to be released, which allows sqlite3 2.0 for ActiveRecord.

zackse avatar Apr 19 '24 22:04 zackse

Super excited for this 🙌

tylerbrewer2 avatar Apr 20 '24 01:04 tylerbrewer2