fauxtograph icon indicating copy to clipboard operation
fauxtograph copied to clipboard
verified publisher icon stitchfix

Python3 compatibility

Open waleedka opened this issue 9 years ago • 2 comments

I encountered several bugs running it on Python 3. I fixed them here in a way compatible with both Python 2 and 3 so everyone's happy. This PR includes:

  • Use BeautifulSoup 4 instead of the obsolete version 3
  • Fix for relative import, which is not the default in py3.
  • Import the reduce() because it's not a builtin funciton in py3.
  • Fixing saving files (string vs bytes).

This update was tested on Python 2.7 and 3.5 on OSX.

waleedka avatar Jul 02 '16 01:07 waleedka

This looks good so far. I'll do some testing and then merge after.

tjtorres avatar Jul 08 '16 19:07 tjtorres

Is there a reason this was never merged? Is this project still maintained?

albell avatar Feb 13 '19 14:02 albell