stitches icon indicating copy to clipboard operation
stitches copied to clipboard

Tests for typescript typings on the stitches code base.

Open ch99q opened this issue 4 years ago • 3 comments

Is your feature request related to a problem? Please describe. Like the existing code base is tested using the unit tests in javascript, but what about the typings? The typescript is one of the most important features of stitches and this part is not yet tested. This feature is more a suggestion to implement typings on the typescript code base.

Describe the solution you'd like Using existing libraries such as tsd or dtslint, those are examples of typescript typings testers.

ch99q avatar Sep 07 '21 07:09 ch99q

I like tsd, and I think it would be good to integrate those into our testing. (I don’t actively dislike dtslint, FWIW).

Would you be interested in helping with this? Otherwise, I think this will be resolved by wiring up tsd.

jonathantneal avatar Sep 08 '21 16:09 jonathantneal

Would you be interested in helping with this? Otherwise, I think this will be resolved by wiring up tsd.

I think tsd would be a good solution, like the expectType function, rather than the expect type comment from dtslint.

Ofc I would be interested in helping :) But we should probably make a list of what we wish to check. It will be hard to validate a type of e.g. createStitiches, due to the extremely large typings output, but rather we focus on validating, the result of ScaleValue, PropertyValue and VariantProps of the result from components? What do you think?

ch99q avatar Sep 12 '21 10:09 ch99q

Doing this after #858 would make things much easier I believe.

kylemh avatar Dec 19 '21 10:12 kylemh