ember-do-forms icon indicating copy to clipboard operation
ember-do-forms copied to clipboard

many failing integration tests after updating to ember 3.8

Open tomwayson opened this issue 6 years ago • 3 comments

After updating our application from ember 3.5 to 3.8 many of our component integration tests started failing Assertion Failed: You cannot specify both a positional param (at position 0) and the hash argument 'controlType'. After looking into it, I discovered the one thing those components had in common was that they use ember-do-form components. I still haven't identified any documented relevant changes in Ember itself between 3.5 and 3.8, but the the components in this addon use positional params and also have controlType.

Has anyone successfully used this addon w/ Ember 3.6+?

tomwayson avatar Jan 14 '20 21:01 tomwayson

FWIW - I do not see these errors when reverting back to 3.5 and upgrading to and installing 3.6 in my app and then re-running the tests. Once I have that merged, I'll try 3.7.

tomwayson avatar Jan 16 '20 00:01 tomwayson

Hey @tomwayson !

I'm not sure what exactly changed in 3.7 / 3.8. Also I haven't touched this addon in a while :( so I'd need to debug this a bit. In any case, from what I remember, positional params are a bit of a no-no now, especially in newer versions of ember. But the most important thing is that ember-one-way-controls which this addon relies on, was deprecated some time ago.

stfcodes avatar Jan 20 '20 09:01 stfcodes

Thanks for replying @shuriu. Our app relies heavily on ember-do-forms, so we're either going to have to figure out how to move beyond this, or replace the dpendency w/ something else.

Do you have a recommendation for a replacement for this addon since you are no longer actively maintaining it and it has deprecated dependencies like ember-one-way-controls?

tomwayson avatar Jan 21 '20 17:01 tomwayson