PSyclone icon indicating copy to clipboard operation
PSyclone copied to clipboard

dotproducttrans fix (closes #1834)

Open rupertford opened this issue 3 years ago • 2 comments

Adds support for explicit array range declarations to the dotproducttrans transformation.

Required for PSyAD with PR #1825.

rupertford avatar Aug 10 '22 14:08 rupertford

Codecov Report

Base: 99.51% // Head: 99.51% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (824a0f7) compared to base (02d0ef9). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1836   +/-   ##
=======================================
  Coverage   99.51%   99.51%           
=======================================
  Files         269      269           
  Lines       39379    39403   +24     
=======================================
+ Hits        39187    39211   +24     
  Misses        192      192           
Impacted Files Coverage Δ
src/psyclone/psyir/nodes/array_mixin.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Aug 10 '22 18:08 codecov[bot]

Ready for first review from @arporter or @sergisiso

rupertford avatar Aug 10 '22 18:08 rupertford

I've added is_lower_bound() and is_upper_bound() tests to array_mixin_test.py. Hopefully that is what you were after.

rupertford avatar Sep 05 '22 11:09 rupertford

Ready for next review from @arporter

rupertford avatar Sep 05 '22 11:09 rupertford

Ready for next review from @arporter subject to CI.

rupertford avatar Sep 12 '22 11:09 rupertford

Not sure what's happened here @rupertford but you've suddenly got some failing tests :-( (I can reproduce these failures locally with Python 3.7.)

arporter avatar Sep 12 '22 12:09 arporter

Broken tests should now be fixed. Apologies.

rupertford avatar Sep 12 '22 13:09 rupertford

There's a link problem in sphinx link check but that's not the fault of this PR.

arporter avatar Sep 12 '22 14:09 arporter