PSyclone icon indicating copy to clipboard operation
PSyclone copied to clipboard

Support for SIR intrinsics (closes #1826)

Open rupertford opened this issue 3 years ago • 4 comments

rupertford avatar Aug 04 '22 20:08 rupertford

Codecov Report

Base: 99.51% // Head: 99.51% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (2565d8c) compared to base (360e788). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1827   +/-   ##
=======================================
  Coverage   99.51%   99.51%           
=======================================
  Files         264      264           
  Lines       39213    39266   +53     
=======================================
+ Hits        39021    39074   +53     
  Misses        192      192           
Impacted Files Coverage Δ
src/psyclone/psyir/backend/sir.py 100.00% <100.00%> (ø)
src/psyclone/tests/psyir/backend/sir_test.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Aug 04 '22 20:08 codecov[bot]

The generated SIR has been checked by Matthias and he is happy that it is correct.

rupertford avatar Aug 05 '22 10:08 rupertford

Ready for first review from @arporter or @sergisiso

rupertford avatar Aug 06 '22 13:08 rupertford

Note, the output has been checked by Matthas @ meteoswiss.

rupertford avatar Aug 06 '22 13:08 rupertford

Ready for next review from @arporter. The validation of the code generation was done by Matthias. He took the output and checked it was OK. Did you want me to try to run the SIR with Dawn locally as well?

rupertford avatar Sep 06 '22 08:09 rupertford