git-js icon indicating copy to clipboard operation
git-js copied to clipboard

custom-binary plugin does not support whitespace

Open skyshineb opened this issue 1 year ago • 1 comments

I've recently stuck with error on other project using this plugin. I have git installed on Windows in C:\Program Files\Git with respective binary path C:\Program Files\Git\bin\git.exe and when SimpleGit is instantiated it receives this path as custom binary. But it will not pass the Regex check ^([a-z]:)?([a-z0-9/.\\_-]+)$ in simple-git/src/lib/plugins/custom-binary.plugin.ts because it does not contain whitespace nor ~(to use with shorten windows path).

Can someone explain to me why this is desired behavior or maybe it's a bug?

skyshineb avatar Nov 11 '24 09:11 skyshineb