Merge "examples-peter" with "master"
Hi Xiang,
Can you please review & accept my pull request, making modifications as you see fit?
I successfully completed a run of example1.m on the PPS cluster. Here is a summary of the results I obtained:
model mean(pvesam)
bvsr 0.2051
bslmm 0.2130
ash 0.1858
Main changes:
- Replaced function
pctfilewithpercentile. - Replaced function
unidrndwithrandint. - Added a script parameter to
example1.mto specify where the data and results are stored.
Let me know if you have any questions or need any assistance with this pull request.
Thanks, Peter
I also added a startup.m file which I use to load the required MATLAB functions (e.g., lightspeed), but feel free to remove this.
Hi Peter,
Thanks! I have a few comments on the changes. Please let me know whether they looks good to you, and then I will merge this pull request immediately.
-
place
percentile.munder themiscfolder:
I think this function might be useful in general, and it is not directly used by any main subroutines (rss_bvsr.m,rss_bslmm.mandrss_ash.m), somiscseems to be a better place for this function. -
hide
randint.minsidepropose_gamma.mandupdate_zlabel.m:
Although this is an obvious duplicate, I am incline to addrandint.mas a local function of bothpropose_gamma.mandupdate_zlabel.m. My main reason is thatrandint.mis only called by these two files.
Once I merge this pull request, I will add two unit tests:
Xiang, that all sounds great to me.
Also, I forgot to mention this before, but please do not delete the examples-peter branch after the pull request. I want to keep this branch to work through example2.m. Thanks.