puppetmodule icon indicating copy to clipboard operation
puppetmodule copied to clipboard

splaylimit has very bad default value

Open olifre opened this issue 8 years ago • 0 comments

In agent.pp, we see: $splaylimit = $::puppet::params::puppet_run_interval, However, this is bad: $::puppet::params::puppet_run_interval is supposed to be in minutes (and multiplied by 60 later in the code), but splaylimit is not multiplied anywhere, so it is in seconds!

This means that, in the default configuration, we will end up with a puppet.conf containing:

runinterval = 1800
splaylimit = 30

which is not at all the same value.

So either the multiplication should be done before using runinterval as a base to define splaylimit, or it should also be done for splaylimit.

olifre avatar Jun 16 '17 00:06 olifre