libmodbus icon indicating copy to clipboard operation
libmodbus copied to clipboard

use poll() instead of select() when possible

Open 2128506 opened this issue 2 years ago • 4 comments

Currently libmodbus uses select() on Linux. If socket handle is greater than FD_SETSIZE select call causes application crash due to buffer overflow. Proposed pull request uses poll() instead of select() when available as well as fails attempts to call select on sockets >= FD_SETSIZE with EBADF. Situation with socket handle being greater that FD_SETSIZE is not uncommon for applications that keeps hundreds of connections.

2128506 avatar Jul 03 '23 10:07 2128506

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient...

cla-bot[bot] avatar Jul 03 '23 10:07 cla-bot[bot]

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient...

cla-bot[bot] avatar Jul 03 '23 12:07 cla-bot[bot]

Related to/fixes #583.

dawagner avatar Jun 11 '24 08:06 dawagner