Jesper Stemann Andersen
Jesper Stemann Andersen
I think this has had enough consideration from my side - unblocking my comments. [noblock]
#68 should fix CI (except for `Invalidations`) fixed CI
Note that the BinaryBuilder recipe (used in #19) is still just re-packaging the Microsoft-binaries for Windows - and for x86_64 Linux with CUDA, so privacy issues may still apply for...
IIRC, the issue with building ONNXRuntime (and Torch) for Windows is building ONNX: https://github.com/JuliaPackaging/Yggdrasil/pull/3839
OK. I just tried simply cherry picking https://github.com/IHPSystems/Torch.jl/commit/e86f40e559e1dce0c8281b7cac3819f261b72939 on top of https://github.com/IHPSystems/Torch.jl/tree/stemann/wrap_torch_1.10 and ran into quite a lot of merge conflicts. So I thought that there might be a small...
Making some progress - I've re-done the edits to the gen.ml script needed for outputting the current generated C api: https://github.com/IHPSystems/Torch.jl/tree/stemann/build_wrapper/build/wrapper_generator
Which functions do you mean ("functions excluded")? I just redefined types in ocaml to match the torch_api_generated files that are currently in this repo. - to be sure I could...
Yes, we should definitely use the up to date tch-rs wrapper generator - just wanted to reproduce the steps for generating 1.4 bindings. The wrapper generators are identical wrt. generating...
Planned course of action: 1. Pin Torch_jll dependency to v1.4 (#55) 2. Build/Register Torch_jll v1.10.2+ (just libtorch - without wrapper) * https://github.com/JuliaPackaging/Yggdrasil/pull/4554 * https://github.com/JuliaPackaging/Yggdrasil/pull/5551 * https://github.com/JuliaPackaging/Yggdrasil/pull/5576 * https://github.com/JuliaPackaging/Yggdrasil/pull/5583 ) 4....
Finally got around to doing something more wrt. bullet point 4 - cf. #56.