stellar-core icon indicating copy to clipboard operation
stellar-core copied to clipboard

Mandate flow control in bytes

Open bboston7 opened this issue 1 year ago • 1 comments

Resolves #3781 and #4374.

This change removes the ENABLE_FLOW_CONTROL_BYTES config option and always uses flow control in bytes.

Checklist

  • [x] Reviewed the contributing document
  • [x] Rebased on top of master (no merge commits)
  • [x] Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
  • [x] Compiles
  • [x] Ran all tests
  • [ ] If change impacts performance, include supporting evidence per the performance document

bboston7 avatar Jun 07 '24 18:06 bboston7

I fully removed the option to disable flow control in bytes and simplified the flow control code. I also bumped the minimum overlay version. This is now ready for another round of review!

bboston7 avatar Jul 29 '24 22:07 bboston7