stellar-client icon indicating copy to clipboard operation
stellar-client copied to clipboard
verified publisher icon stellar

if you create a pair and then delete your gateway it shows up as BTC/STR (undefined)

Open jedmccaleb opened this issue 11 years ago • 6 comments

clarification added by iris: if you create a pair and then remove the gateway using manage currencies, it shows up as BTC/STR (undefined)

jedmccaleb avatar Oct 08 '14 05:10 jedmccaleb

PR https://github.com/stellar/stellar-client/pull/970 makes a lot of changes to this system. This bug might not be reproducible after it is merged. Check back after it is merged.

irisli avatar Oct 08 '14 23:10 irisli

This is not reproducible anymore. I'm guessing that #970 fixed it.

irisli avatar Oct 13 '14 22:10 irisli

Closing issue

bekkibolthouse avatar Oct 13 '14 22:10 bekkibolthouse

@irisli I just reproduced this behavior.

screen shot 2014-10-13 at 3 47 33 pm

When we revoke trust from a gateway it is completely removed form the wallet. Since you could still hold their credits, and therefore continue to trade, we should persist the gateway in the user's wallet after revoking trust.

deckar01 avatar Oct 13 '14 22:10 deckar01

Misunderstood, thought it was about deleting a pair.

This seems like something we need to discuss about. Should we keep traces of that gateway until all the credits are removed? Then we delete the gateway completely after the user doesn't have those credits anymore.

irisli avatar Oct 13 '14 22:10 irisli

We will need the gateway info even after the credits are gone to properly show the trade history.

deckar01 avatar Oct 13 '14 23:10 deckar01