timoni icon indicating copy to clipboard operation
timoni copied to clipboard

[RFC] refactor`cmd/timoni`

Open errordeveloper opened this issue 1 year ago • 3 comments

errordeveloper avatar Mar 12 '24 11:03 errordeveloper

@stefanprodan I've rebased and made it green, there is still some work, but maybe woth a quick review whenever you have a chance?

errordeveloper avatar Apr 09 '24 10:04 errordeveloper

@errordeveloper looks great so far. Will you be adding deletion to the reconciler package?

stefanprodan avatar Apr 24 '24 15:04 stefanprodan

I can add deletion methods in this PR or leave for another one, what would you prefer?

errordeveloper avatar Apr 24 '24 15:04 errordeveloper

I can add deletion methods in this PR or leave for another one, what would you prefer?

I would leave it for another PR, this has lots of good things already, thank you!

stefanprodan avatar May 24 '24 15:05 stefanprodan

I would leave it for another PR, this has lots of good things already, thank you!

Ok, I have cleaned up most of the commits, just the last two need some attention. I can resolve sometime soon, but feel free to do it if you would like to merge. The revert commit needs to be drop with its original commit and the empty TODO commit would need to be dropped.

errordeveloper avatar May 25 '24 16:05 errordeveloper

...just the last two need some attention.

all done now!

errordeveloper avatar Jun 10 '24 18:06 errordeveloper

@stefanprodan should be good to merge now!

errordeveloper avatar Jun 10 '24 20:06 errordeveloper