libvips-lambda icon indicating copy to clipboard operation
libvips-lambda copied to clipboard

Fixes to build libvips in December 2019

Open boltronics opened this issue 6 years ago • 4 comments

It's been a while since this project was last updated, and many of the URLs were no longer working.

Additionally, it seems a number of bugs were introduced in recent commits, such as the seemingly accidental removal of the xml2.sh file contents, or the command to tar up a modules directory unconditionally, regardless of the PHP modules being built (and that directory existing or not).

Due to needing to perform a lot of rebuilds until all issues were sorted, I found it helpful to have dependency downloads cached instead of re-fetched each time. This might also help someone if some of the downloads disappear later but another rebuild is required.

I also adjusted the MAKEFLAGS to have builds run faster, but this seemed to be incompatible with a single make install command to build and install, so I separated dependency builds out into separate make and make install steps which seems to work for me.

While a couple of problematic dependency versions have had a bump to a newer release, I have not checked and updated any other dependencies. I can confirm with these changes I could successfully build a working libvips 8.8.3, which is the latest version as of writing.

boltronics avatar Dec 04 '19 07:12 boltronics

Let me know when you are ready to merge?

Also, if you are interested in taking over maintenance ... well, we haven't used it in over 1.5 years. I'm actually building libvips alongside PHP and others such that they all share the same updated libraries in a different repo. Interested?

bubba-h57 avatar Dec 05 '19 13:12 bubba-h57

Thanks @bubba-h57 for looking at the PR request and for the maintainer offer. I'm not sure right now how much I'll be using this project going forward. It could be quite a lot, or not at all, so I might have to wait and see and get back to you.

I previously thought this PR was good to merge when I initially opened it, but then as you've no doubt noticed, I found a couple more things to change. Perhaps it might be better if I confirm I'm happy with everything in the next week or so, if that's okay with you?

boltronics avatar Dec 05 '19 22:12 boltronics

Absolutely!

bubba-h57 avatar Dec 05 '19 23:12 bubba-h57

@boltronics I'm trying to get your changes to build, and they do build successfully. However, when trying to confirm the installation, I'm running ./run-interactive.sh to simply output the version of vips.

When unpackaging the generated tar in the dist folder and then attempting to run ./bin/vips -v I receive the following response.

./bin/vips: error while loading shared libraries: libvips.so.42: cannot open shared object file: No such file or directory

smcguinness avatar Dec 09 '19 18:12 smcguinness