bench: refactor to use string interpolation in array/base/atnd
type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report:
- task: lint_filenames status: passed
- task: lint_editorconfig status: passed
- task: lint_markdown status: na
- task: lint_package_json status: na
- task: lint_repl_help status: na
- task: lint_javascript_src status: na
- task: lint_javascript_cli status: na
- task: lint_javascript_examples status: na
- task: lint_javascript_tests status: na
- task: lint_javascript_benchmarks status: na
- task: lint_python status: na
- task: lint_r status: na
- task: lint_c_src status: na
- task: lint_c_examples status: na
- task: lint_c_benchmarks status: na
- task: lint_c_tests_fixtures status: na
- task: lint_shell status: na
- task: lint_typescript_declarations status: passed
- task: lint_typescript_tests status: na
- task: lint_license_headers status: passed
Resolves a part of #8647.
Description
What is the purpose of this pull request?
This pull request:
- Refactors the JavaScript benchmark in
@stdlib/array/base/atndto use@stdlib/string/formatfor string interpolation instead of string concatenation when specifying the benchmark name
Related Issues
Does this pull request have any related issues?
This pull request has the following related issues:
- Resolves a part of #8647
Questions
Any questions for reviewers of this pull request?
No.
Other
Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.
No.
Checklist
Please ensure the following tasks are completed before submitting this pull request.
- [x] Read, understood, and followed the contributing guidelines.
AI Assistance
When authoring the changes proposed in this PR, did you use any kind of AI assistance?
- [ ] Yes
- [x] No
If you answered "yes" above, how did you use AI assistance?
- [ ] Code generation (e.g., when writing an implementation or fixing a bug)
- [ ] Test/benchmark generation
- [ ] Documentation (including examples)
- [ ] Research and understanding
Disclosure
If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".
@stdlib-js/reviewers
:wave: Hi there! :wave:
And thank you for opening your first pull request! We will review it shortly. :runner: :dash:
Getting Started
- Please read our contributing guidelines if you haven't already.
- For development guidance, refer to the development guide.
Next Steps
- A project maintainer will approve GitHub Actions workflows for your PR.
- All CI checks must pass before your submission can be fully reviewed.
- You'll need to address any failures in linting or unit tests.
Running Tests Locally
You can use make to run any of the CI commands locally from the root directory of the stdlib repository:
# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"
# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"
If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.
If you have any further questions while waiting for a response, please join our Gitter channel to chat with project maintainers and other community members.
We appreciate your contribution!
Documentation Links
Coverage Report
| Package | Statements | Branches | Functions | Lines |
|---|---|---|---|---|
| array/base/atnd | $\color{green}120/120$ $\color{green}+0.00%$ |
$\color{green}10/10$ $\color{green}+0.00%$ |
$\color{green}1/1$ $\color{green}+0.00%$ |
$\color{green}120/120$ $\color{green}+0.00%$ |
The above coverage report was generated for the changes in this PR.
Thank you for your contribution and congratulations on your first PR!