feat: add assign and strided methods to csignumf
Resolves #6507
Description
What is the purpose of this pull request?
This pull request: introduces additional functionality and documentation for the @stdlib/math/base/special/csignumf package. Specifically, it:
- Implements two new methods:
-
csignumf.assign(re, im, out, strideOut, offsetOut)for assigning the result of the signum function to an output array. -
csignumf.strided(z, sz, oz, out, so, oo)for evaluating the signum function on strided array data.
-
- Adds corresponding test files:
-
test.assign.js -
test.strided.js
-
- Adds performance benchmarks:
-
benchmark.assign.js -
benchmark.strided.js
-
- Updates the documentation to include usage examples and interface descriptions for the new methods.
Related Issues
No
Does this pull request have any related issues?
This pull request:
- resolves #6507
Questions
Any questions for reviewers of this pull request?
No.
Other
Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.
Output of
➜ make test TEST_FILTER=".*/@stdlib/math/base/special/csignumf.*"
Last Few lines
➜ make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/csignumf.*"
Click here for complete benchmark.log
Checklist
Please ensure the following tasks are completed before submitting this pull request.
- [x] Read, understood, and followed the contributing guidelines.
@stdlib-js/reviewers
Coverage Report
| Package | Statements | Branches | Functions | Lines |
|---|---|---|---|---|
| math/base/special/csignumf | $\color{green}369/369$ $\color{green}+100.00\%$ |
$\color{green}11/11$ $\color{green}+100.00\%$ |
$\color{green}4/4$ $\color{green}+100.00\%$ |
$\color{green}369/369$ $\color{green}+100.00\%$ |
| ndarray/base/zeros | $\color{green}124/124$ $\color{green}+100.00\%$ |
$\color{green}7/7$ $\color{green}+100.00\%$ |
$\color{green}1/1$ $\color{green}+100.00\%$ |
$\color{green}124/124$ $\color{green}+100.00\%$ |
The above coverage report was generated for the changes in this PR.
Hi, just checking in kindly — please let me know if there's anything else needed on my end to move this PR forward. Thanks :)
@Deepak91168 This PR requires quite a few changes. I’d recommend closely following the reference implementation and applying similar modifications here. Thanks for your work!
https://github.com/stdlib-js/stdlib/commit/486fed2b9816530eb135f9846f3745281cec76e2#diff-21f0b814eeab6be07313a2f02453372f37d95323a6ba4961f06843be96deceb9
@Deepak91168 This PR requires quite a few changes. I’d recommend closely following the reference implementation and applying similar modifications here. Thanks for your work!
486fed2#diff-21f0b814eeab6be07313a2f02453372f37d95323a6ba4961f06843be96deceb9
Thanks for Reviewing! Will be incorporating each change recommended.
Thanks for Reviewing! Will be incorporating each change recommended.
Awesome! "Recommended changes + double-check anything else that doesn’t match the reference implementation".
Thanks for Reviewing! Will be incorporating each change recommended.
Awesome! "Recommended changes + double-check anything else that doesn’t match the reference implementation".
Hey! I've made all the requested changes, closely following the referenced implementation. Please let me know if anything else needs adjustment. Thanks again for the thorough review!