stdlib-js
feat: refactor and native addons for `complex/float64/conj`
type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report:
- task: lint_filenames status: passed
- task: lint_editorconfig status: passed
- task: lint_markdown status: na
- task: lint_package_json status: na
- task: lint_repl_help status: na
- task: lint_javascript_src status: passed
- task: lint_javascript_cli status: na
- task: lint_javascript_examples status: na
- task: lint_javascript_tests status: passed
- task: lint_javascript_benchmarks status: passed
- task: lint_python status: na
- task: lint_r status: na
- task: lint_c_src status: missing_dependencies
- task: lint_c_examples status: na
- task: lint_c_benchmarks status: na
- task: lint_c_tests_fixtures status: na
- task: lint_shell status: na
- task: lint_typescript_declarations status: na
- task: lint_typescript_tests status: na
- task: lint_license_headers status: passed ---
none
Description
What is the purpose of this pull request?
This pull request:
- Adds native addon and refactor the implementation for
complex/float64/conj
Related Issues
Does this pull request have any related issues?
This pull request:
- none
Questions
Any questions for reviewers of this pull request?
No.
Other
Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.
No.
Checklist
Please ensure the following tasks are completed before submitting this pull request.
- [x] Read, understood, and followed the contributing guidelines.
@stdlib-js/reviewers
Coverage Report
| Package | Statements | Branches | Functions | Lines |
|---|---|---|---|---|
| complex/float64/conj | $\color{green}143/143$ $\color{green}+100.00\%$ |
$\color{green}5/5$ $\color{green}+100.00\%$ |
$\color{green}2/2$ $\color{green}+100.00\%$ |
$\color{green}143/143$ $\color{green}+100.00\%$ |
The above coverage report was generated for the changes in this PR.
@ShabiShett07 In order for the native add-on to compile, you need to add the *.gyp files. This was why the addon.c bug was not caught.
Added gyp files to this, just needed confirmation for the structure and got it from @kgryte