stdlib icon indicating copy to clipboard operation
stdlib copied to clipboard

refactor: c implementation of `blas/base/ssyr`

Open ShabiShett07 opened this issue 8 months ago • 1 comments


type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report:

  • task: lint_filenames status: passed
  • task: lint_editorconfig status: passed
  • task: lint_markdown status: passed
  • task: lint_package_json status: na
  • task: lint_repl_help status: na
  • task: lint_javascript_src status: na
  • task: lint_javascript_cli status: na
  • task: lint_javascript_examples status: na
  • task: lint_javascript_tests status: na
  • task: lint_javascript_benchmarks status: na
  • task: lint_python status: na
  • task: lint_r status: na
  • task: lint_c_src status: missing_dependencies
  • task: lint_c_examples status: na
  • task: lint_c_benchmarks status: na
  • task: lint_c_tests_fixtures status: na
  • task: lint_shell status: na
  • task: lint_typescript_declarations status: na
  • task: lint_typescript_tests status: na
  • task: lint_license_headers status: passed ---

Progresses #2039.

Description

What is the purpose of this pull request?

This pull request:

  • Adds separate implementation for ndarray of blas/base/ssyr

Related Issues

Does this pull request have any related issues?

This pull request:

  • progresses #2039

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

ShabiShett07 avatar May 30 '25 12:05 ShabiShett07

Coverage Report

Package Statements Branches Functions Lines
blas/base/ssyr $\color{green}616/616$
$\color{green}+100.00\%$
$\color{green}82/82$
$\color{green}+100.00\%$
$\color{green}5/5$
$\color{green}+100.00\%$
$\color{green}616/616$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

stdlib-bot avatar May 30 '25 13:05 stdlib-bot

@ShabiShett07 Now that https://github.com/stdlib-js/stdlib/pull/6566 has been merged, this PR can move forward. You'll also want to include the changes I made in the follow-up commit which I linked to on https://github.com/stdlib-js/stdlib/pull/6566.

kgryte avatar Jul 11 '25 08:07 kgryte

/stdlib merge

kgryte avatar Jul 11 '25 08:07 kgryte

/stdlib merge

@kgryte, the slash command failed to complete. Please check the workflow logs for details.

View workflow run

stdlib-bot avatar Jul 11 '25 08:07 stdlib-bot

/stdlib merge

ShabiShett07 avatar Jul 11 '25 10:07 ShabiShett07

@ShabiShett07 Another follow-up commit for dsyr: https://github.com/stdlib-js/stdlib/commit/a41c427ee9ddd87f48288a737ea9820ea48b5498

kgryte avatar Jul 12 '25 01:07 kgryte