stdlib icon indicating copy to clipboard operation
stdlib copied to clipboard

feat: implement betaincinv function

Open devesssi opened this issue 10 months ago • 2 comments

Resolves #649

Description

What is the purpose of this pull request?

This pull request:

  • Implements the inverse incomplete beta function (betaincinv) as a native Node.js addon
  • Provides a JavaScript wrapper with input validation and error handling
  • Includes comprehensive test suite, examples, and benchmarks
  • Adds documentation with usage examples and parameter descriptions

The implementation uses the Newton-Raphson method to find the inverse of the incomplete beta function, which is useful in various statistical applications including hypothesis testing and confidence interval calculations.

Related Issues

Does this pull request have any related issues?

This pull request:

  • Resolves #649 by implementing the inverse incomplete beta function

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? functionadded

Implementation Details:

  • Uses Newton-Raphson method for finding the inverse
  • Implements the incomplete beta function using continued fraction expansion
  • Handles edge cases and invalid inputs
  • Includes proper error handling and input validation

Technical Requirements:

  • Node.js >=14.0.0 <19.0.0
  • Uses node-addon-api for native module binding
  • No breaking changes functionadded

Checklist

Please ensure the following tasks are completed before submitting this pull request.

  • [x] Read, understood, and followed the contributing guidelines
  • [x] Added comprehensive test suite
  • [x] Added examples and benchmarks
  • [x] Added documentation with usage examples
  • [x] Implemented proper error handling
  • [x] Added input validation
  • [x] Used consistent code style
  • [x] Added appropriate license headers
  • [x] Added proper type definitions
  • [x] Added proper JSDoc comments

@stdlib-js/reviewers

devesssi avatar Apr 04 '25 15:04 devesssi

:warning: Tracking Issue Closure Warning :warning:

I noticed your PR description contains closing keywords ("Resolves", "Closes", or "Fixes") referencing a "Tracking Issue".

Why this matters: Tracking issues should typically remain open until all related sub-issues are completed. GitHub automatically closes issues with such closing keywords when the PR is merged. For more information, see GitHub's documentation on using keywords in issues and pull requests.

Required action: Use "Progresses" instead to reference the tracking issue without automatically closing it.

Thank you for your contribution to the project!

Planeshifter avatar Apr 10 '25 00:04 Planeshifter

Thankyou sir for taking time to comment🙏

devesssi avatar Jun 02 '25 06:06 devesssi