stdlib icon indicating copy to clipboard operation
stdlib copied to clipboard

feat: add C implementation for `number/float32/base/signbit`

Open Planeshifter opened this issue 3 years ago • 6 comments

Description

What is the purpose of this pull request?

This pull request:

  • adds a C implementation for @stdlib/number/float32/base/signbit

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves #
  • fixes #

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Opening this PR to test out and incrementally improve our AI workflow for scaffolding packages, which includes addition of C implementations. I expect to delete and re-run the respective scaffolding workflows multiple times as I continue improving the scaffolding outputs.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

Planeshifter avatar Nov 15 '22 01:11 Planeshifter

Based off the README.md file, the stdlib-bot has generated contents for the signbitf package and pushed them to the pull request branch.

Notes

  • :warning: The stdlib-bot uses AI to generate package content. The generated content is not guaranteed to be correct, and will require manual review and editing. :warning:

github-actions[bot] avatar Nov 15 '22 13:11 github-actions[bot]

Should I open another branch for implementing this? @kgryte @Planeshifter

Pranavchiku avatar Dec 02 '22 06:12 Pranavchiku

@Pranavchiku You can move on to a different package. @Planeshifter needs to tidy this one up.

kgryte avatar Dec 02 '22 06:12 kgryte

@Planeshifter Should we go ahead and close this PR or are you interested in getting this in?

kgryte avatar Jun 11 '24 08:06 kgryte

PR Commit Message

feat: add C implementation for `number/float32/base/signbit`

PR-URL: https://github.com/stdlib-js/stdlib/pull/623
Signed-off-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

stdlib-bot avatar Sep 14 '24 16:09 stdlib-bot

PR Commit Message

feat: add C implementation for `number/float32/base/signbit`

PR-URL: https://github.com/stdlib-js/stdlib/pull/623

Please review the above commit message and make any necessary adjustments.

stdlib-bot avatar Sep 21 '24 19:09 stdlib-bot

/stdlib help

Planeshifter avatar Nov 14 '24 03:11 Planeshifter

@Planeshifter, available slash commands include:

  • /stdlib check-files - Check for required files.
  • /stdlib update-copyright-years - Update copyright header years.
  • /stdlib lint-autofix - Auto-fix lint errors.
  • /stdlib merge - Merge changes from develop branch into this PR.
  • /stdlib rebase - Rebase this PR on top of develop branch.

stdlib-bot avatar Nov 14 '24 03:11 stdlib-bot

/stdlib merge

Planeshifter avatar Nov 14 '24 03:11 Planeshifter

/stdlib merge

Planeshifter avatar Nov 14 '24 03:11 Planeshifter

/stdlib nuke

Planeshifter avatar Nov 14 '24 03:11 Planeshifter

@Planeshifter, slash command not recognized. Please use /stdlib help to view available commands.

stdlib-bot avatar Nov 14 '24 03:11 stdlib-bot

/stdlib merge

Planeshifter avatar Nov 15 '24 02:11 Planeshifter

/stdlib merge

Planeshifter avatar Nov 16 '24 00:11 Planeshifter

/stdlib update-copyright-years

Planeshifter avatar Nov 16 '24 01:11 Planeshifter

@Planeshifter I've updated the PR title to avoid confusion.

kgryte avatar Dec 11 '24 09:12 kgryte

/stdlib merge

Planeshifter avatar Dec 19 '24 00:12 Planeshifter