stdlib icon indicating copy to clipboard operation
stdlib copied to clipboard

feat: add `math/base/special/exp2f`

Open aayush0325 opened this issue 1 year ago • 8 comments

Progresses #649

Description

What is the purpose of this pull request?

This pull request:

  • adds math/base/special/exp2f

Related Issues

Does this pull request have any related issues?

This pull request:

  • progresses #649

Questions

Any questions for reviewers of this pull request?

What should i do about benchmark/c/cephes ? that doesn't seem to compile locally and on the CI tests as well.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

aayush0325 avatar Dec 07 '24 17:12 aayush0325

/stdlib update-copyright-years

aayush0325 avatar Dec 07 '24 17:12 aayush0325

Coverage Report

Package Statements Branches Functions Lines
math/base/special/exp2f $\color{green}333/333$
$\color{green}+100.00\%$
$\color{green}21/21$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}333/333$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

stdlib-bot avatar Dec 07 '24 17:12 stdlib-bot

good morning @Planeshifter! I've wrapped the intermediate results and final answers in float64ToFloat32(). If there's anything else that needs to be changed here please let me know.

aayush0325 avatar Dec 15 '24 03:12 aayush0325

Also, as mentioned in the questions section of the PR, what should i do about benchmark/c/cephes since it doesn't seem to compile locally and it fails on CI as well. Is there something that I'm missing from my side? (see this commit)

aayush0325 avatar Dec 15 '24 03:12 aayush0325

/stdlib update-copyright-years

gunjjoshi avatar Mar 19 '25 17:03 gunjjoshi

@aayush0325 You still interested in pushing this PR forward?

kgryte avatar Apr 02 '25 23:04 kgryte

/stdlib merge

aayush0325 avatar Apr 02 '25 23:04 aayush0325

good morning @gunjjoshi! sorry for the delay, I've linked to all the references for your ease, kindly let me know if i have to make any other changes

aayush0325 avatar Apr 03 '25 01:04 aayush0325

@anandkaranubc Would you mind taking over this PR?

kgryte avatar Aug 12 '25 07:08 kgryte

/stdlib merge

anandkaranubc avatar Aug 26 '25 07:08 anandkaranubc