stdlib icon indicating copy to clipboard operation
stdlib copied to clipboard

feat: add C `ndarray` API and refactor `blas/ext/base/dnansumors`

Open headlessNode opened this issue 1 year ago • 3 comments

Resolves none.

Description

What is the purpose of this pull request?

This pull request:

  • Adds C ndarray API and refactor/cleanup blas/ext/base/dnansumors

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

headlessNode avatar Oct 11 '24 09:10 headlessNode

@headlessNode Do you know the reason for the lint failure on CI?

kgryte avatar Oct 11 '24 11:10 kgryte

@kgryte I tried to find it in this PR but didn't find anything in the C files that could be causing this.

headlessNode avatar Oct 11 '24 12:10 headlessNode

@headlessNode @kgryte To me, it looks like the C lint failures are due to cppcheck installation failing. Could have to do with latest GitHub Actions runner upgrade. Failures are not due to changes in this PR and are occurring in other PRs as well. We may need to look into the compilation failures. Upgrading cppcheck to a newer version could also be explored.

Planeshifter avatar Oct 12 '24 17:10 Planeshifter

@Planeshifter Upgrading cppcheck seems to have caused other build failures when linting C files. The failing build does not appear to be due to changes in this PR. As such, I will go ahead and merge.

kgryte avatar Oct 26 '24 07:10 kgryte