stdlib-js
feat: add `math/base/special/gcdf`
Resolves part of #649 .
Description
What is the purpose of this pull request?
This pull request:
- adds
math/base/special/gcdf
Related Issues
Does this pull request have any related issues?
This pull request:
- resolves part of #649
Questions
Any questions for reviewers of this pull request?
No.
Other
Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.
- Open to reviews !!
Checklist
Please ensure the following tasks are completed before submitting this pull request.
- [x] Read, understood, and followed the contributing guidelines.
@stdlib-js/reviewers
Thanks @aayush0325, we'll require fmodf to proceed with this. Once we have that, we can come back here.
Thanks for your time @gunjjoshi , I have applied the changes from the code review, please ping this PR when fmodf gets added.
@aayush0325 fmodf (added by @gunjjoshi in https://github.com/stdlib-js/stdlib/pull/3059) has now landed, so this branch can be rebased on the latest code on develop and updated to make use of it.
@Planeshifter , i've rebased the branch and made the changes but when i try to push them it looks through all the changed files (due to rebasing i think) and there's apparently a linting error in one of them so i'm not able to push my code. how to proceed here.
@aayush0325 You can bypass the hook by pushing with the --no-verify flag added to your git push command
PR Commit Message
feat: add `math/base/special/gcdf`
PR-URL: https://github.com/stdlib-js/stdlib/pull/2997
Ref: https://github.com/stdlib-js/stdlib/issues/649
Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Aayush Khanna <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
Please review the above commit message and make any necessary adjustments.
