stdlib icon indicating copy to clipboard operation
stdlib copied to clipboard

feat: add `fs/resolve-parent-paths-by`

Open gururaj1512 opened this issue 1 year ago • 7 comments

Resolves #2567.

Description

What is the purpose of this pull request? Adds JS implementation for @stdlib/fs/resolve-parent-paths-by/

This pull request:

  • resolves https://github.com/stdlib-js/stdlib/issues/2567

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves #2567

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

gururaj1512 avatar Sep 12 '24 19:09 gururaj1512

hey @kgryte, can you explain this linting error in README file at line 3. Screenshot 2024-09-16 165059

gururaj1512 avatar Sep 16 '24 11:09 gururaj1512

@gururaj1512 is this when you try to commit?

Snehil-Shah avatar Sep 16 '24 15:09 Snehil-Shah

@Snehil-Shah that error occurs when commiting and also while running eslint

gururaj1512 avatar Sep 16 '24 15:09 gururaj1512

@gururaj1512 Weird. I can't seem to reproduce the error. Did you follow the setup guide properly? (make install, make init). Maybe try clean installing and setting up again (after make clean). Also, can you show the full error and what exactly are/were you trying to commit?

Snehil-Shah avatar Sep 16 '24 15:09 Snehil-Shah

@gururaj1512 Weird. I can't seem to reproduce the error. Did you follow the setup guide properly? (make install, make init). Maybe try clean installing and setting up again (after make clean). Also, can you show the full error and what exactly are/were you trying to commit?

Yaa, I have tried make clean & make install Lint Error This error occurs while running command npx eslint path/to/directory/

gururaj1512 avatar Sep 16 '24 21:09 gururaj1512

@gururaj1512 Weird. I can't seem to reproduce the error. Did you follow the setup guide properly? (make install, make init). Maybe try clean installing and setting up again (after make clean). Also, can you show the full error and what exactly are/were you trying to commit?

Yaa, I have tried make clean & make install Lint Error This error occurs while running command npx eslint path/to/directory/

Ok, was able to reproduce it. Seems to me, it's something specific to npx as I am able to commit the file without any errors. And in any case, you don't need to run npx eslint manually, the linter is automatically triggered before every commit via git hooks (assuming your environment is set up as expected). If you still wish to manually trigger the linter, you can use the make recipes (like make lint) listed here.

Snehil-Shah avatar Sep 16 '24 22:09 Snehil-Shah

Also, was the issue with your dev environment resolved @gururaj1512?

@Snehil-Shah, the issue with my dev environment has been resolved. Thank you for checking in!

gururaj1512 avatar Sep 23 '24 05:09 gururaj1512

@kgryte, Modified the code to address race conditions. Can you re-review it.

gururaj1512 avatar Nov 13 '24 18:11 gururaj1512

/stdlib merge

kgryte avatar Nov 18 '24 04:11 kgryte

/stdlib merge

kgryte avatar Nov 25 '24 06:11 kgryte

Coverage Report

Package Statements Branches Functions Lines
fs/resolve-parent-paths-by $\color{red}923/952$
$\color{green}+96.95\%$
$\color{red}127/136$
$\color{green}+93.38\%$
$\color{green}26/26$
$\color{green}+100.00\%$
$\color{red}923/952$
$\color{green}+96.95\%$

The above coverage report was generated for the changes in this PR.

stdlib-bot avatar Nov 25 '24 06:11 stdlib-bot