stdlib icon indicating copy to clipboard operation
stdlib copied to clipboard

refactor: use constant packages, `FI_F` for addon and style fixes in `math/base/special/ldexpf`

Open gunjjoshi opened this issue 1 year ago • 0 comments

Description

What is the purpose of this pull request?

This pull request:

  • addresses the changes suggested in the commit: https://github.com/stdlib-js/stdlib/commit/71c43cf5165749e2ce2647cb52d92f6c97f16959.
  • uses FI_F in addon.c.
  • Regarding the 100% test coverage, I tried different values, but there wasn't any pair of arguments for which the function reaches this block. So, I removed it in both implementations.
  • contains some other style fixes.

Related Issues

Does this pull request have any related issues?

None.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

gunjjoshi avatar Sep 06 '24 16:09 gunjjoshi