stdlib icon indicating copy to clipboard operation
stdlib copied to clipboard

feat: add `ndarray/base/fill`

Open headlessNode opened this issue 1 year ago • 3 comments

Progresses #2656.

Description

What is the purpose of this pull request?

This pull request:

  • Adds implementation of ndarray/base/fill

Related Issues

Does this pull request have any related issues?

This pull request:

  • Progresses #2656

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

headlessNode avatar Aug 21 '24 13:08 headlessNode

@kgryte I think the benchmarks and tests will essentially be similar to ndarray/base/assign?

headlessNode avatar Aug 21 '24 13:08 headlessNode

the benchmarks and tests will essentially be similar to ndarray/base/assign

Yes, I think so.

kgryte avatar Aug 21 '24 17:08 kgryte

@kgryte Done. Please review, thanks!

headlessNode avatar Aug 23 '24 19:08 headlessNode

@kgryte I realized after adding all the benchmarks that you meant to add benchmarks for 2d only. So its up to you if you want to remove the other benchmarks.

headlessNode avatar Sep 07 '24 09:09 headlessNode