stdlib-js
[RFC]: add schema and validation for syntax highlighting themes in the REPL
Description
This RFC proposes adding JSON schema and validation for when a user is providing their own set of themes. Currently, the user can provide any object as a theme without them knowing what's wrong.
Related Issues
Follow up to #2291
Questions
No.
Other
No.
Checklist
- [X] I have read and understood the Code of Conduct.
- [X] Searched for existing issues and pull requests.
- [X] The issue name begins with
RFC:.
One thing that we'd need to consider is whether to make ajv a production dependency, or whether we should roll our own JSON schema validator. The implementation of ajv does not appear trivial: https://github.com/ajv-validator/ajv/tree/master. In order to be a production dependency, we'd need to ensure it works across our supported environments.
I'll go ahead and mark this as "blocked" until we figure out the path forward.
@monyishh This issue is currently "blocked" due to reasons discussed above. If you have anything you want to add to the discussion and have any ideas you want to propose, feel free to.