[RFC]: Add/Update package for `BooleanArray` support (tracking issue)
Description
This RFC proposes add or update all packages that needs to be changed in order to add BooleanArray support to Stdlib. The purpose of this issue is to serve as a tracking issue for update or add packages.
Packages need to added:
- [x]
@stdlib/assert/is-booleanarray - [x]
@stdlib/strided/base/reinterpret-boolean - [x]
@stdlib/array/base/assert/is-booleanarray - [x]
@stdlib/assert/is-same-booleanarray
Packages need to updated:
- [x]
@stdlib/array/dtypes - [x]
@stdlib/array/dtype - [ ]
@stdlib/array/bool- add methods ofBooleanArrayandrepl.txt - [x]
@stdlib/array/ctors - [ ]
@stdlib/array/convert - [ ]
@stdlib/array/convert-same- update tests and benchmarks - [x]
@stdlib/array/defaults - [x]
@stdlib/array/docs/types - [x]
@stdlib/array/empty - [x]
@stdlib/array/empty-like - [ ]
@stdlib/array/filled - [ ]
@stdlib/array/filled-by - [ ]
@stdlib/array/from-scalar- add tests - [x]
@stdlib/array/full - [x]
@stdlib/array/full-like - [x]
@stdlib/array/mostly-safe-casts - [x]
@stdlib/array/next-dtype - [ ]
@stdlib/array/pool - [x]
@stdlib/array/promotion-rules - [x]
@stdlib/array/safe-casts - [x]
@stdlib/array/same-kind-casts - [x]
@stdlib/array/reviver - [x]
@stdlib/array/to-json - [x]
@stdlib/array/typed-ctors - [x]
@stdlib/array/typed-dtypes - [x]
@stdlib/array/typed - [x]
@stdlib/array/base/any - [x]
@stdlib/array/base/assert/has-same-values - [x]
@stdlib/array/base/count-falsy - [x]
@stdlib/array/base/count-truthy - [ ]
@stdlib/array/base/count-same-value - [ ]
@stdlib/array/base/count-same-value-zero - [x]
@stdlib/array/base/cuany - [x]
@stdlib/array/base/cuevery - [x]
@stdlib/array/base/every - [x]
@stdlib/array/base/mskfilter - [x]
@stdlib/array/base/mskreject - [x]
@stdlib/array/base/none - [x]
@stdlib/array/base/take
Related Issues
None
Questions
No.
Other
No.
Checklist
- [X] I have read and understood the Code of Conduct.
- [X] Searched for existing issues and pull requests.
- [X] The issue name begins with
RFC:.
:wave: Hi there! :wave:
And thank you for opening your first issue! We will get back to you shortly. :runner: :dash:
@Jaysukh-409 Looks like we also need to update various packages in @stdlib/array/base/assert/* to support boolean data types. Should add those packages to the list, as well.
The list should also include:
- typed-dtypes
- typed
- promotion-rules
- next-dtype
- safe-casts
- same-kind-casts
- from-scalar (tests)
- pool
- to-json
@Jaysukh-409 I updated the OP with additional array/base/* packages which need to be updated to specially handle BooleanArrays. I've added boolean array support to @stdlib/array/base/put and the updates to the various "base" packages will be along similar lines. Namely, where possible, reinterpreting a boolean array to allow more efficient element access.
As all tasks in this tracking issue are now completed, I'll go ahead and close. Thanks, @Jaysukh-409!