stdlib icon indicating copy to clipboard operation
stdlib copied to clipboard

[BUG]: test workflow is not running tests in nested test directories

Open kgryte opened this issue 1 year ago • 0 comments

Description

In https://github.com/stdlib-js/stdlib/actions/runs/8496433869/job/23273812132?pr=1680, I noticed that not all tests were running. As can be observed in https://github.com/stdlib-js/stdlib/pull/1680, we have tests in nested directories. Locally, these tests were failing, but CI did not catch. The reason for this is that CI only attempts to run tests at the top-level of the test folder within a package.

Line which needs to be updated:

https://github.com/stdlib-js/stdlib/blob/3080f032a477cbd046b4201d7ffdd407c9d93816/.github/workflows/scripts/run_affected_tests#L154

Related Issues

No.

Questions

  • What was the rationale for limiting test filtering to the top-level test directory? Why were nested tests ignored?

Demo

No response

Reproduction

  • See https://github.com/stdlib-js/stdlib/pull/1680 for an example test folder setup.

Expected Results

No response

Actual Results

No response

Version

No response

Environments

Node.js

Browser Version

No response

Node.js / npm Version

No response

Platform

No response

Checklist

  • [X] Read and understood the Code of Conduct.
  • [X] Searched for existing issues and pull requests.

kgryte avatar Mar 31 '24 07:03 kgryte