feat: add C implementation for `math/base/special/sin`
Description
What is the purpose of this pull request?
This pull request:
Adds native C implementation for @stdlib/math/base/special/sin
double stdlib_base_sin ( const double x );
Related Issues
Issue Tracker: https://github.com/stdlib-js/stdlib/issues/2018
This pull request:
- Adds C Implementation of @stdlib/node_moudles/math/base/special/sin
Questions
Any questions for reviewers of this pull request?
No.
Other
Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.
No.
Checklist
Please ensure the following tasks are completed before submitting this pull request.
- [ ] Read, understood, and followed the contributing guidelines.
@stdlib-js/reviewers
NOTE: The sin function contains precision upto 4 floating points. (ie. +-0.00001) Thanks!
@xaman27x As is, we cannot accept the changes introduced in this PR. Please ensure you study how other packages include C implementations.
E.g., don't write your own
binding.gypfile, copy it from other packages, comments and all.You shouldn't be modifying the contents of
package.json, except forgypfileanddirectories. Use projectMakefiles, copying them from other packages.We have project tooling for compilation. Learn that tooling.
Your addon interface does not conform to our conventions.
Your C implementation needs considerable work.
sindepends onrempio2: https://svnweb.freebsd.org/base/release/9.3.0/lib/msun/src/s_sin.c?view=markup. Meaning, the prerequisite for adding a C implementation tosinhas not been satisfied in order to add this implementation.
Alright! I'll copy all necessary files henceforth! And since the Sin implementation requires C implementation of 'rempio2' as well, I'll work upon that first! Thank you for consideration Best.
This PR has been superseded by #2349. Will go ahead and close. Thank you, @xaman27x, for your interest in stdlib.