stdlib icon indicating copy to clipboard operation
stdlib copied to clipboard

RFC: add the Boltzmann distribution

Open kgryte opened this issue 7 years ago • 5 comments

Checklist

Please ensure the following tasks are completed before filing an issue.

  • [x] Read and understood the Code of Conduct.
  • [x] Searched for existing issues and pull requests.
  • [x] If this is a general question, searched the FAQ for an existing answer.
  • [x] If this is a feature request, the issue name begins with RFC:.

Description

Description of the issue (or feature request).

This RFC proposes adding the Boltzmann distribution. Similar to other distribution namespaces, adding support for the Boltzmann distribution would entail a family of packages for evaluating the PMF, CDF, mean, median, etc.

Namespace: @stdlib/stats/base/dists/boltzmann Reference: @stdlib/stats/base/dists/*

Related Issues

Does this issue (or feature request) have any related issues?

No.

Questions

Any questions for reviewers?

No.

Other

Any other information relevant to this issue (or feature request)? This may include screenshots, references, stack traces, sample output, and/or implementation notes.

Reference implementations:

kgryte avatar May 02 '18 17:05 kgryte

@kgryte I would like to work on this issue.

AgPriyanshu18 avatar Mar 31 '24 18:03 AgPriyanshu18

@AgPriyanshu18 Thanks for volunteering to work on this. Feel free to submit one or more PRs implementing this functionality. In fact, it may be good to split it over multiple PRs just to simplify review.

kgryte avatar Mar 31 '24 20:03 kgryte

@kgryte @Planeshifter, I have stuck on linkting issues with Readme file. Screenshot from 2024-04-02 09-59-39

The code block on readme file giving issue is Screenshot from 2024-04-02 10-00-46

PMF Factory method code block is Screenshot from 2024-04-02 10-01-45

There is no variable named fact in Readme. I would request your help in this issue.

AgPriyanshu18 avatar Apr 01 '24 23:04 AgPriyanshu18

But there is a variable named fact in your pmf function, and you haven't declared it. You need to add var fact; to the pmf function you show in your last screenshot.

kgryte avatar Apr 02 '24 01:04 kgryte

@kgryte @Planeshifter Thanks for your help. I have added the PMF function for Boltzmann distribution.

AgPriyanshu18 avatar Apr 02 '24 06:04 AgPriyanshu18