stdlib icon indicating copy to clipboard operation
stdlib copied to clipboard

refactor: improve type definitions for ndarray array

Open prajwalkulkarni opened this issue 1 year ago • 1 comments

Resolves #1088

Description

What is the purpose of this pull request?

This pull request:

  • Improves type definition of ndarray's array function.
  • Infers return type based on the passed dtype's value, else uses buffer arguments' type.

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves #1088

Questions

Any questions for reviewers of this pull request?

@Planeshifter From my understanding, I'm assuming the type of buffer argument and the type of buffer property in options argument are the same? Please let me know if otherwise.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

prajwalkulkarni avatar Feb 26 '24 18:02 prajwalkulkarni

@Planeshifter could you kindly review this PR?

prajwalkulkarni avatar Mar 15 '24 17:03 prajwalkulkarni